feat(torch): v1 resources added

[tty47]

Overview

Checklist

• New and updated code has appropriate documentation
• New and updated code has new and/or updated testing
• Required CI checks are passing
• Visual proof for any user facing features like CLI or documentation updates
• Linked issues closed with keywords

[Bidon15]

If you still want to use context.TODO() - please give a very comprehensive reasoning why instead of other type of contexts 🙏

Great job so far!

[Bidon15]

As a good practice you need to pass context downstream so you can have a select case if the context is either done or not

[tty47]

I've updated these functions, now they look like:

// ProcessTaskQueue processes the pending tasks in the queue the time specified in the const TickerTime.
func ProcessTaskQueue(ctx context.Context) {
	ticker := time.NewTicker(TickerTime)

	for {
		select {
		case <-ctx.Done():
			// The context has been canceled, exit the loop.
			return
		case <-ticker.C:
			processQueue(ctx)
		}
	}
}

// processQueue process the nodes in the queue and tries to generate the Multi Address
func processQueue(ctx context.Context) {
	red := redis.InitRedisConfig()

	for {
		select {
		case <-ctx.Done():
			// The context has been canceled, exit the loop.
			return
		case peer := <-taskQueue:
			// Perform the operation with the node
			err := CheckNodesInDBOrCreateThem(peer, red, ctx)
			if err != nil {
				log.Error("Error checking the nodes: CheckNodesInDBOrCreateThem - ", err)
			}
		}
	}
}

is this the right usage as you mentioned?

[Bidon15]

🖖 another round please 🙏

[Bidon15]

I highly recommend you return errors up the call stack as the never ending loop of calls based on ticker and no exit is bad design pick

[Bidon15]

Ideally here you need to process errors returned from processQueue()
Also, you need to return a general error or nil error in ProcessTaskQueue() func as it is a good practice

[Bidon15]

it's not good to do taskQueue like this.

You can either create a struct that holds the queue functions or only create it in AddPhase

[Bidon15]

It's not good that we are not doing error handling here

[tty47]

we will review the pending points here:
https://github.com/celestiaorg/devops/issues/576