feat: new metrics from Torch #1
Conversation
Signed-off-by: Jose Ramon Mañes <[email protected]>
Signed-off-by: Jose Ramon Mañes <[email protected]>
Signed-off-by: Jose Ramon Mañes <[email protected]>
Signed-off-by: Jose Ramon Mañes <[email protected]>
| attribute.String("service_name", serviceName), | ||
| attribute.String("block_height_1", blockHeight), | ||
| attribute.String("earliest_block_time", earliestBlockTime), | ||
| attribute.Int("days_running", CalculateDaysDifference(earliestBlockTime)), |
There was a problem hiding this comment.
[non-blocking]
Is it possible to set the timestamp when the chain was started, and calculate how many days it's running in the frontend?
To my knowledge it's inefficient for monitoring systems to save metrics with labels that change over time. If I remember correctly, it's because of Prometheus saves metrics.
There was a problem hiding this comment.
that would be great, but for now, I think is not possible due to the Grafana transformation doesn't have this feature yet to add calculations to attributes
I tried it before and I couldn't find a way to do it...
There was a problem hiding this comment.
Interesting. What is the reason for having the "days running" as an attribute and not as a metric value? Like a timestamp.
(I don't think we should change your code, as it works. I want to understand different methods)
There was a problem hiding this comment.
I guess blockchain hash can't be a metric value, as it's a string, right?
There was a problem hiding this comment.
Interesting. What is the reason for having the "days running" as an attribute and not as a metric value? Like a timestamp.
(I don't think we should change your code, as it works. I want to understand different methods)
do you mean to set the value of the metric to the days running?, I think it is more clear to use an attribute, because the metric is called earliest_block_time which contains more data, another option could be just to create a new metric called days_running(or whatever), and set the value to it 🤔 I don't discard this option, we can split this info in a different metrics
wdyt?
the change is tiny, I'll only need a good name for the metric 😌
There was a problem hiding this comment.
I would say no, we are using the metric type: Float64ObservableGauge, and the blockchain hash is a string... that's why we are setting the value 1 to the metric (also to make it like activated)
hello team!
I've added a couple of new metrics to torch.
the results look like:
You can find it: here
they are deployed in
robusta-torch-1, the metrics have been tested and seem to work fine.Thanks in advance! 🚀
Jose Ramon Mañes
closes: https://github.com/celestiaorg/devops/issues/468