Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade to pfm v6.1.2 #3332

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Apr 16, 2024

Closes #3331. The import path rename was motivated by cosmos/ibc-apps#121

@rootulp rootulp self-assigned this Apr 16, 2024
@rootulp rootulp requested a review from a team as a code owner April 16, 2024 16:28
@rootulp rootulp requested review from ramin and ninabarbakadze and removed request for a team April 16, 2024 16:28
Copy link
Contributor

coderabbitai bot commented Apr 16, 2024

Walkthrough

Walkthrough

The changes involve updating import paths in app/app.go and test/packetforward/packetforward_upgrade_test.go to align with the latest project structure modifications. Additionally, the packetforward middleware is upgraded to version 6.1.2 to address security concerns.

Changes

Files Change Summary
app/app.go,
.../packetforward_upgrade_test.go
Updated import paths and upgraded packetforward.

Assessment against linked issues

Objective Addressed Explanation
Update PFM to 6.1.2 (#3331)
Investigate migration path from ibc-go v6.2.1 to v7.0.0+ (#3128) The PR focuses on updating packetforward and not ibc-go.

Possibly related issues

  • Upgrade to ibc-go v7.0.0+ #3128: This issue discusses upgrading ibc-go to v7.0.0+. Although not directly addressed in this PR, the upgrade of related middleware might necessitate revisiting ibc-go version dependencies in the future.

Recent Review Details

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between d60eef7 and ae203d4.
Files ignored due to path filters (4)
  • go.mod is excluded by !**/*.mod
  • go.sum is excluded by !**/*.sum
  • test/testground/go.mod is excluded by !**/*.mod
  • test/testground/go.sum is excluded by !**/*.sum
Files selected for processing (2)
  • app/app.go (1 hunks)
  • test/packetforward/packetforward_upgrade_test.go (1 hunks)
Additional comments not posted (3)
test/packetforward/packetforward_upgrade_test.go (2)

16-16: Updated import path for packetforwardtypes to reflect the new project structure.


16-16: Ensure that the updated import path is correctly used in the test setup and assertions.

Verification successful

The verification process focused on ensuring that the updated import path packetforwardtypes "github.com/cosmos/ibc-apps/middleware/packet-forward-middleware/v6/packetforward/types" is correctly used in the test setup and assertions within the file test/packetforward/packetforward_upgrade_test.go.

From the script output, it is evident that the import path is used in the test file. Specifically, the packetforwardtypes alias is utilized to access ModuleName and KeyFeePercentage within the test assertions. This confirms that the import path is not only included but is actively used in the logic of the test, which aligns with the expectations set in the review comment.

Given this information, the import path's usage in the test setup and assertions is verified as correct.

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Verify that the new import path is correctly used in the test setup and assertions.
rg --type go 'packetforwardtypes' -- 'test/packetforward/packetforward_upgrade_test.go'

Length of output: 394

app/app.go (1)

104-106: Updated import paths for packetforward and related packages to align with the new project structure.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rootulp rootulp requested review from cmwaters and removed request for ramin April 16, 2024 16:28
@celestia-bot celestia-bot requested a review from a team April 16, 2024 16:28
@rootulp rootulp merged commit 13a485d into celestiaorg:main Apr 17, 2024
34 checks passed
@rootulp rootulp deleted the rp/pfm-6.1.2 branch April 17, 2024 00:07
ninabarbakadze pushed a commit to ninabarbakadze/celestia-app that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update PFM to 6.1.2
3 participants