Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define hypotenuse function using fma #1513

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Conversation

sethrj
Copy link
Member

@sethrj sethrj commented Nov 19, 2024

Following on to #1510 this adds a hypot function to allow us to add a platform-independent and potentially higher accuracy definition. The current implementation uses std::fma rather than ipow to reduce the number of floating point operations and registers.

@sethrj sethrj added core Software engineering infrastructure minor Minor internal changes or fixes labels Nov 19, 2024
Copy link
Contributor

@amandalund amandalund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition!

@sethrj sethrj enabled auto-merge (squash) November 19, 2024 16:18
@sethrj sethrj merged commit 0b7a411 into celeritas-project:develop Nov 19, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Software engineering infrastructure minor Minor internal changes or fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants