Search by code #598
Open
Search by code #598
+98
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -18,6 +18,7 @@ def all | |||
| Subject | |||
| .where("lower(unaccent(name)) LIKE lower(unaccent(?))", "%#{params[:search].strip}%") | |||
| .or(Subject.where("lower(unaccent(short_name)) LIKE lower(unaccent(?))", "%#{params[:search].strip}%")) | |||
| .or(Subject.where("lower(unaccent(code)) LIKE lower(unaccent(?))", "%#{params[:search].strip}%")) | |||
There was a problem hiding this comment.
Es necesario el unaccent si estamos usando el código para buscar? Entiendo que el lower si así tanto si buscás por 'mi2' o por 'MI2' vas a encontrar a Matemática inicial
| @@ -71,7 +71,7 @@ | |||
| <%= form_with(url: all_subjects_path, method: :get, local: true) do |f| %> | |||
| <div class="mdc-text-field mdc-text-field--filled mdc-text-field--label-floating mdc-text-field--no-label mdc-text-field--with-trailing-icon"> | |||
| <span class="mdc-text-field__ripple"></span> | |||
| <%= f.text_field :search, value: params[:search], class: "mdc-text-field__input", placeholder: "Buscar", autofocus: true, data: { 'search-target': "searchInput" } %> | |||
| <%= f.text_field :search, value: params[:search], class: "mdc-text-field__input", placeholder: "Busqueda por nombre o codigo de la materia", autofocus: true, data: { 'search-target': "searchInput" } %> | |||
There was a problem hiding this comment.
typo:
Suggested change
| <%= f.text_field :search, value: params[:search], class: "mdc-text-field__input", placeholder: "Busqueda por nombre o codigo de la materia", autofocus: true, data: { 'search-target': "searchInput" } %> | |
| <%= f.text_field :search, value: params[:search], class: "mdc-text-field__input", placeholder: "Búsqueda por nombre o codigo de la materia", autofocus: true, data: { 'search-target': "searchInput" } %> |
Aunque creo que me gusta un poco más el verbo en infinitivo:
Suggested change
| <%= f.text_field :search, value: params[:search], class: "mdc-text-field__input", placeholder: "Busqueda por nombre o codigo de la materia", autofocus: true, data: { 'search-target': "searchInput" } %> | |
| <%= f.text_field :search, value: params[:search], class: "mdc-text-field__input", placeholder: "Buscar por nombre o código de la materia", autofocus: true, data: { 'search-target': "searchInput" } %>o |
There was a problem hiding this comment.
Tenemos un par de tests de sistema que testean medio lo que estamos testeando acá. Por ejemplo uno que testea que se oculten y se muestren las materias correctas y otro que testea la funcionalidad de buscar materias.
Qué te parece simplemente añadir un par de expectations más al último para testear que buscar por código anda y después vemos de mover esos tests de Minitest a RSpec como follow up?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to search a subject by the code
Also, making the X in the search bar clears the text input