Fixed "This function declaration is not a prototype" errors in Xcode 9 #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Woah, rad. Thanks for the PR Steven ! I’ll take some time to merge this PR tonight but it looks eminently mergeable. Out of curiosity, did you look at the test failure ? Is it unrelated or did this manage to break anything in our test suite ? |
|
It looks unrelated to me: Locally, I get hundreds of lines of error output from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cedar's headers declare no-args functions in a way that means "this function takes no arguments" in C++ but "this function takes an unspecified number of arguments" in C and Objective-C. With the default project settings applied, Xcode treats those declarations as errors.