Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing 2 bugs with IDs #673

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Fixing 2 bugs with IDs #673

merged 1 commit into from
Feb 28, 2024

Conversation

aaronjeline
Copy link
Contributor

@aaronjeline aaronjeline commented Feb 28, 2024

Description of changes

  1. Entity types with the id Set were mistakenly interpreted as having the id set
  2. A mistake the CFG could lead to a panic when parsing a schema that used in as an entity type name

Issue #, if available

N/A

Checklist for requesting a review

The change in this PR is (choose one, and delete the other options):

  • A bug fix or other functionality change requiring a patch to cedar-policy.

I confirm that this PR (choose one, and delete the other options):

  • Does not update the CHANGELOG because my change does not significantly impact released code.

I confirm that cedar-spec (choose one, and delete the other options):

  • Does not require updates because my change does not impact the Cedar formal model or DRT infrastructure.

Disclaimer

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: Aaron Eline <[email protected]>
@aaronjeline aaronjeline merged commit fb09925 into main Feb 28, 2024
12 checks passed
@aaronjeline aaronjeline deleted the schema-ids-bugfix branch February 28, 2024 18:52
@khieta khieta mentioned this pull request Feb 28, 2024
3 tasks
aaronjeline added a commit that referenced this pull request Feb 29, 2024
aaronjeline added a commit that referenced this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants