Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use educe in more places #1365

Merged
merged 1 commit into from
Dec 9, 2024
Merged

use educe in more places #1365

merged 1 commit into from
Dec 9, 2024

Conversation

cdisselkoen
Copy link
Contributor

Description of changes

  • Uses educe to replace more manual impls of PartialEq, PartialOrd, and Hash.
  • For TemplateBody, this is a functional change -- the PartialEq and Hash implementations now ignore the loc field.

Issue #, if available

Checklist for requesting a review

The change in this PR is (choose one, and delete the other options):

  • A change "invisible" to users (e.g., documentation, changes to "internal" crates like cedar-policy-core, cedar-validator, etc.)

I confirm that this PR (choose one, and delete the other options):

  • Does not update the CHANGELOG because my change does not significantly impact released code.

I confirm that cedar-spec (choose one, and delete the other options):

  • Does not require updates because my change does not impact the Cedar formal model or DRT infrastructure.

I confirm that docs.cedarpolicy.com (choose one, and delete the other options):

  • Does not require updates because my change does not impact the Cedar language specification.

Signed-off-by: Craig Disselkoen <[email protected]>
@cdisselkoen cdisselkoen merged commit 35e953f into main Dec 9, 2024
19 checks passed
@cdisselkoen cdisselkoen deleted the cdisselkoen/educe branch December 9, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants