Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply clippy --fix and also fix some other clippy warnings #1346

Merged
merged 4 commits into from
Dec 2, 2024

Conversation

cdisselkoen
Copy link
Contributor

No description provided.

Signed-off-by: Craig Disselkoen <[email protected]>
Copy link
Contributor

@john-h-kastner-aws john-h-kastner-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but presumably this is intended to fix the CI failure?

@cdisselkoen
Copy link
Contributor Author

yeah I'm applying some manual clippy fixes as well, hang on

@cdisselkoen cdisselkoen changed the title Apply clippy --fix Apply clippy --fix and also fix some other clippy warnings Dec 2, 2024
Signed-off-by: Craig Disselkoen <[email protected]>
Signed-off-by: Craig Disselkoen <[email protected]>
@adpaco-aws adpaco-aws merged commit edd14d3 into main Dec 2, 2024
19 checks passed
@cdisselkoen cdisselkoen deleted the cdisselkoen/clippy branch December 2, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants