Cedar protobuf structures #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Disselkoen <[email protected]>
Signed-off-by: Craig Disselkoen <[email protected]>
Signed-off-by: Craig Disselkoen <[email protected]>
Signed-off-by: Craig Disselkoen <[email protected]>
…ages Signed-off-by: Craig Disselkoen <[email protected]>
Signed-off-by: Craig Disselkoen <[email protected]>
Signed-off-by: Craig Disselkoen <[email protected]>
Signed-off-by: Craig Disselkoen <[email protected]>
Signed-off-by: Craig Disselkoen <[email protected]>
Signed-off-by: Craig Disselkoen <[email protected]>
Signed-off-by: Craig Disselkoen <[email protected]>
Signed-off-by: Craig Disselkoen <[email protected]>
…tobuf Signed-off-by: Craig Disselkoen <[email protected]>
Signed-off-by: Craig Disselkoen <[email protected]>
Signed-off-by: Craig Disselkoen <[email protected]>
emina
approved these changes
Nov 26, 2024
Signed-off-by: Craig Disselkoen <[email protected]>
emina
approved these changes
Nov 26, 2024
Signed-off-by: Craig Disselkoen <[email protected]>
emina
approved these changes
Nov 26, 2024
Signed-off-by: Craig Disselkoen <[email protected]>
|
CI failure on this latest commit (which only updates a comment) when it passed on the previous commit, is definitely unrelated and should be resolved separately. It's a failure to build code in |
john-h-kastner-aws
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a Lean library for parsing Cedar protobuf structures produced by the Rust implementation (with the Rust
protobufsfeature). Code originally by @Brandon-Rozek ; I have refactored and cleaned up some parts, and added a lot of tests.As of this writing, several tests are failing, but reviews are still welcome on the code itself. Some of the failing tests are due to my attempts to add entity-tags support to Brandon's existing code.Tests are now passing and this is ready for review. Changes vs Brandon's code include adding entity-tags support and a lot of tests, as well as some refactoring.