Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/exp/ast: move internal ast into the x/exp package #70

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

philhassey
Copy link
Collaborator

@philhassey philhassey commented Nov 26, 2024

This PR moves the internal ast package from internal/ast to be publicly available as x/exp/ast. This enables people to inspect / analyze ASTs that loaded from Cedar policy files, JSON policy files, or crafted using the programmatic AST.

By leaving it in the x/exp/ast package, it is not being declared as stable yet.

This PR marks a step towards resolving an issue requesting this feature:
#37

Addresses IDX-225

Signed-off-by: philhassey <[email protected]>
@philhassey philhassey changed the title x/exp/ast: move ast into the x/exp package x/exp/ast: move internal ast into the x/exp package Nov 26, 2024
Copy link
Collaborator

@kjamieson-sdm kjamieson-sdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The move looks good, though please revise the PR description and/or commit message to record the reason for this change (which I think I know, but would be nice to record for history).

@philhassey philhassey merged commit 9d338bc into cedar-policy:main Nov 26, 2024
3 checks passed
@philhassey philhassey deleted the move-ast-to-exp branch November 26, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants