Expose extension function calls in AST package #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patjakdev
approved these changes
Nov 9, 2024
ast/ast_test.go
Outdated
| func TestAstExamples(t *testing.T) { | ||
| t.Parallel() | ||
| // This example shows how you can construct polcies with the ast package | ||
| func ExampleNode() { |
There was a problem hiding this comment.
Yes, thank you! We've been meaning to do this.
I think we could actually elevate these up to just Example() so that they appear right at the top of the documentation.
micahhausler
force-pushed
the
extension-ast-calls
branch
from
bf5d722 to
d1aa68b
Compare
Signed-off-by: Micah Hausler <[email protected]>
micahhausler
force-pushed
the
extension-ast-calls
branch
from
d1aa68b to
b9ff4a5
Compare
|
Fixed conflicts, updated test example to package-level |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Resolves #54
Description of changes:
This change adds support for specifically calling extension functions in the AST package.