bash completions #563
Draft
bash completions #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a source is selected with -s for cluset -L then we correctly list it first, but there is no need to print the prefix
just clush for now
degremont
reviewed
Jul 1, 2024
| -w|-x) | ||
| options="$(cluset ${groupsource:+-s "$groupsource"} -L 2>/dev/null)" | ||
| ;; | ||
| _g|--group|-X) |
thiell
added a commit
to thiell/clustershell
that referenced
this pull request
Sep 9, 2024
Let -s source behave as if it replaces the default group source, and thus omit the source prefix for the groups in that source. Part of cea-hpc#563.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 14, 2024
Let -s source behave as if it replaces the default group source, and thus omit the source prefix for the groups in that source. Part of #563.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just clush for now; might be some bugs but seems to work.
perf-wise it calls
cluset -Lon every tab, we might need to cache the result somewhere if it is slow in some setups.(But if user changes conf files it won't be reloaded so that's a bit annoying, it's better not to cache if it's reasonable e.g. just reading the conf files)
Prereq patch makes
cluset -s foo -Lnot listfoogroups with the@foo:prefix, like default source with-L-- this allowsclush -s foo -w @barto complete properly.