refactor: reword error log for when a GC Notify request times out (#792)

cds-snc · Aug 29, 2024 · 132e992 · 132e992
1 parent 78d2bc9
commit 132e992
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/lambda-code/cognito-email-sender/lib/gc-notify-client.ts b/lambda-code/cognito-email-sender/lib/gc-notify-client.ts
@@ -51,14 +51,14 @@ export class GCNotifyClient {
            * is an instance of XMLHttpRequest in the browser and an instance
            * of http.ClientRequest in Node.js
            */
-          errorMessage = `Error sending to Notify with request :${error.request}.`;
+          errorMessage = `Request timed out.`;
         }
       } else if (error instanceof Error) {
         errorMessage = `${(error as Error).message}.`;
       }
 
       throw new Error(
-        `Failed to send submission through GC Notify to ${emailAddress}. Reason: ${errorMessage}.`
+        `Failed to send submission through GC Notify to ${emailAddress}. Reason: ${errorMessage}`
       );
     }
   }

diff --git a/lambda-code/nagware/lib/gc-notify-client.ts b/lambda-code/nagware/lib/gc-notify-client.ts
@@ -51,14 +51,14 @@ export class GCNotifyClient {
            * is an instance of XMLHttpRequest in the browser and an instance
            * of http.ClientRequest in Node.js
            */
-          errorMessage = `Error sending to Notify with request :${error.request}.`;
+          errorMessage = `Request timed out.`;
         }
       } else if (error instanceof Error) {
         errorMessage = `${(error as Error).message}.`;
       }
 
       throw new Error(
-        `Failed to send submission through GC Notify to ${emailAddress}. Reason: ${errorMessage}.`
+        `Failed to send submission through GC Notify to ${emailAddress}. Reason: ${errorMessage}`
       );
     }
   }

diff --git a/lambda-code/reliability/lib/gc-notify-client.ts b/lambda-code/reliability/lib/gc-notify-client.ts
@@ -51,14 +51,14 @@ export class GCNotifyClient {
            * is an instance of XMLHttpRequest in the browser and an instance
            * of http.ClientRequest in Node.js
            */
-          errorMessage = `Error sending to Notify with request :${error.request}.`;
+          errorMessage = `Request timed out.`;
         }
       } else if (error instanceof Error) {
         errorMessage = `${(error as Error).message}.`;
       }
 
       throw new Error(
-        `Failed to send submission through GC Notify to ${emailAddress}. Reason: ${errorMessage}.`
+        `Failed to send submission through GC Notify to ${emailAddress}. Reason: ${errorMessage}`
       );
     }
   }