Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CNAMEs for ai-answers domain #439

Closed
wants to merge 1 commit into from
Closed

feat: add CNAMEs for ai-answers domain #439

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions terraform/ai-answers.alpha.canada.ca.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
resource "aws_route53_record" "ai-answers-alpha-canada-ca-CNAME" {
zone_id = aws_route53_zone.alpha-canada-ca-public.zone_id
name = "ai-answers.alpha.canada.ca"
type = "CNAME"
records = [
"react-answers.vercel.app"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this should be hosted in Vercel, I'd be okay if it was hosted in our secure cloud environments instead

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that if this product becomes live, it will need an ATO (could be a short term one), and a migration to a different cloud will likely be required.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to take a hard stance and say I will not approve this until it migrates to a Secure cloud enviroment

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not just Vercel I have an issue with it's the underlying API's that are in use, it needs to be migrated to Azure's Open AI API's.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

]
ttl = "300"
}

resource "aws_route53_record" "reponses-ia-alpha-canada-ca-CNAME" {
zone_id = aws_route53_zone.alpha-canada-ca-public.zone_id
name = "reponses-ia.alpha.canada.ca"
type = "CNAME"
records = [
"react-answers.vercel.app"
]
ttl = "300"
}
Loading