Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CNAMEs for ai-answers domain #439

Closed
wants to merge 1 commit into from
Closed

Conversation

patheard
Copy link
Member

@patheard patheard commented Dec 4, 2024

Summary

Create English and French CNAMES for the AI answers service.

/cc @HamzaAburaneh

Related

Create English and French CNAMES for the AI answers service.
@patheard patheard requested a review from a team as a code owner December 4, 2024 20:28
@patheard patheard self-assigned this Dec 4, 2024
Copy link

github-actions bot commented Dec 4, 2024

DNS

✅   Terraform Init: success
✅   Terraform Validate: success
✅   Terraform Format: success
✅   Terraform Plan: success
✅   Conftest: success

Plan: 2 to add, 0 to change, 0 to destroy
Show summary
CHANGE NAME
add aws_route53_record.ai-answers-alpha-canada-ca-CNAME
aws_route53_record.reponses-ia-alpha-canada-ca-CNAME
Show plan
Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # aws_route53_record.ai-answers-alpha-canada-ca-CNAME will be created
  + resource "aws_route53_record" "ai-answers-alpha-canada-ca-CNAME" {
      + allow_overwrite = (known after apply)
      + fqdn            = (known after apply)
      + id              = (known after apply)
      + name            = "ai-answers.alpha.canada.ca"
      + records         = [
          + "react-answers.vercel.app",
        ]
      + ttl             = 300
      + type            = "CNAME"
      + zone_id         = "Z33C47YI9EN8XL"
    }

  # aws_route53_record.reponses-ia-alpha-canada-ca-CNAME will be created
  + resource "aws_route53_record" "reponses-ia-alpha-canada-ca-CNAME" {
      + allow_overwrite = (known after apply)
      + fqdn            = (known after apply)
      + id              = (known after apply)
      + name            = "reponses-ia.alpha.canada.ca"
      + records         = [
          + "react-answers.vercel.app",
        ]
      + ttl             = 300
      + type            = "CNAME"
      + zone_id         = "Z33C47YI9EN8XL"
    }

Plan: 2 to add, 0 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Saved the plan to: plan.tfplan

To perform exactly these actions, run the following command to apply:
    terraform apply "plan.tfplan"
Show Conftest results
WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.Route53TerraformDeploy"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.notify_prod_dns_manager_policy"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_role.notify_prod_dns_manager"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_user.dns-github-deployer"]
WARN - plan.json - main - Missing Common Tags: ["aws_route53_zone.alpha-canada-ca-public"]
WARN - plan.json - main - Missing Common Tags: ["aws_route53_zone.cds-snc-ca-public"]
WARN - plan.json - main - Missing Common Tags: ["aws_route53_zone.platform-canada-ca-public"]

26 tests, 19 passed, 7 warnings, 0 failures, 0 exceptions

@HamzaAburaneh
Copy link

Hello, if there is ever any issues this is the contact email: [email protected]

@patheard patheard marked this pull request as draft December 4, 2024 20:36
Copy link
Member

@CalvinRodo CalvinRodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please migrate to one of the official CDS hosting solutions

name = "ai-answers.alpha.canada.ca"
type = "CNAME"
records = [
"react-answers.vercel.app"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this should be hosted in Vercel, I'd be okay if it was hosted in our secure cloud environments instead

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that if this product becomes live, it will need an ATO (could be a short term one), and a migration to a different cloud will likely be required.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to take a hard stance and say I will not approve this until it migrates to a Secure cloud enviroment

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not just Vercel I have an issue with it's the underlying API's that are in use, it needs to be migrated to Azure's Open AI API's.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@patheard
Copy link
Member Author

Closing for now. Will reopen once hosting questions have been resolved.

@patheard patheard closed this Dec 18, 2024
@patheard patheard deleted the feat/ai-answers-cname branch December 18, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New domain request for ai-answers.alpha.canada.ca
4 participants