-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add CNAMEs for ai-answers domain #439
Conversation
Create English and French CNAMES for the AI answers service.
DNS✅ Terraform Init: Plan: 2 to add, 0 to change, 0 to destroy Show summary
Show planResource actions are indicated with the following symbols:
+ create
Terraform will perform the following actions:
# aws_route53_record.ai-answers-alpha-canada-ca-CNAME will be created
+ resource "aws_route53_record" "ai-answers-alpha-canada-ca-CNAME" {
+ allow_overwrite = (known after apply)
+ fqdn = (known after apply)
+ id = (known after apply)
+ name = "ai-answers.alpha.canada.ca"
+ records = [
+ "react-answers.vercel.app",
]
+ ttl = 300
+ type = "CNAME"
+ zone_id = "Z33C47YI9EN8XL"
}
# aws_route53_record.reponses-ia-alpha-canada-ca-CNAME will be created
+ resource "aws_route53_record" "reponses-ia-alpha-canada-ca-CNAME" {
+ allow_overwrite = (known after apply)
+ fqdn = (known after apply)
+ id = (known after apply)
+ name = "reponses-ia.alpha.canada.ca"
+ records = [
+ "react-answers.vercel.app",
]
+ ttl = 300
+ type = "CNAME"
+ zone_id = "Z33C47YI9EN8XL"
}
Plan: 2 to add, 0 to change, 0 to destroy.
─────────────────────────────────────────────────────────────────────────────
Saved the plan to: plan.tfplan
To perform exactly these actions, run the following command to apply:
terraform apply "plan.tfplan"
Show Conftest resultsWARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.Route53TerraformDeploy"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.notify_prod_dns_manager_policy"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_role.notify_prod_dns_manager"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_user.dns-github-deployer"]
WARN - plan.json - main - Missing Common Tags: ["aws_route53_zone.alpha-canada-ca-public"]
WARN - plan.json - main - Missing Common Tags: ["aws_route53_zone.cds-snc-ca-public"]
WARN - plan.json - main - Missing Common Tags: ["aws_route53_zone.platform-canada-ca-public"]
26 tests, 19 passed, 7 warnings, 0 failures, 0 exceptions
|
Hello, if there is ever any issues this is the contact email: [email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please migrate to one of the official CDS hosting solutions
name = "ai-answers.alpha.canada.ca" | ||
type = "CNAME" | ||
records = [ | ||
"react-answers.vercel.app" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this should be hosted in Vercel, I'd be okay if it was hosted in our secure cloud environments instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that if this product becomes live, it will need an ATO (could be a short term one), and a migration to a different cloud will likely be required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am going to take a hard stance and say I will not approve this until it migrates to a Secure cloud enviroment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not just Vercel I have an issue with it's the underlying API's that are in use, it needs to be migrated to Azure's Open AI API's.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Closing for now. Will reopen once hosting questions have been resolved. |
Summary
Create English and French CNAMES for the AI answers service.
/cc @HamzaAburaneh
Related