fix(ci): remove invalid properties from force-release workflow #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiehan
requested review from
mutahhir and
DanielMSchmidt
and removed request for
a team
Signed-off-by: team-tf-cdk <[email protected]>
team-tf-cdk
approved these changes
Aug 27, 2024
|
I'm going to lock this pull request because it has been closed for at least 7 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue so we can investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, the rollout of #437 failed because it turns out there was some invalid syntax in the
force-releaseworkflow, which theaction-validatorpackage was failing the build on. This highlighted one flaw of this setup: because theforce-releaseworkflow doesn't exist in this project, and only in the prebuilt providers / implementers of this project, it wasn't being run through the validation at build/test time here in the source, and so it's possible to write a bad workflow here, publish a release, and break all implementing projects as a result.In order to be a good citizen, I not only fixed the issue with
force-releaseitself but also figured out how to add tests for all of the workflows, again usingaction-validator. I manually verified that with the bad syntax still included inforce-release.ts, the tests were failing (as they should). When I removed the bad syntax, all the tests pass. Win!