Skip to content

Commit

Permalink
chore: have lock-threads fail silently (#426)
Browse files Browse the repository at this point in the history
There's really no reason to have our monitoring dashboard color red when
this workflow fails, which happens pretty regularly due to rate-limiting
issues that are hard to avoid.

Note that this is not a totally ideal solution because now we won't know
if the workflow starts failing 100% of the time for any reason, but
given that I don't think that's super likely and the status quo is
annoying, I consider that a small price to pay.
  • Loading branch information
xiehan authored Jul 4, 2024
1 parent be2d1c9 commit 471b018
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions src/lock-issues.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ export class LockIssues {
},
},
],
continueOnError: true, // this job fails quite frequently due to rate limit issues but it's really not a big deal if it does
});
}
}
5 changes: 5 additions & 0 deletions test/__snapshots__/index.test.ts.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 471b018

Please sign in to comment.