chore(src/clients): improved error handling #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryparker
added
enhancement
ryparker
changed the title
rix0rrr
requested changes
Nov 22, 2022
src/clients.ts
Outdated
|
|
||
| const spawn = spawnSync('gh', ['repo', 'view', '--json', 'nameWithOwner'], { stdio: ['ignore', 'pipe', 'pipe'] }); | ||
| const stderr = spawn.stderr?.toString(); | ||
| if (stderr) { |
There was a problem hiding this comment.
Not a fan of this. Can’t we get an exit code?
There was a problem hiding this comment.
Sure. We can throw on non 0 exit codes. Are you cool with keeping the stderr output in the message or would you rather not 'pipe' it?
const spawn = spawnSync('gh', args, { input: value, stdio: ['pipe', 'inherit', 'pipe'] });
if (spawn.status !== 0) {
throw new Error(`Failed to store secret '${name}' in repository '${repository}'. ${spawn.stderr?.toString()}`);
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds improved error handling when interfacing with the GitHub CLI or AWS SecretsManager.
When I first used this project I did not have permission to one of the repos it was trying to swap secrets for. It silently failed and caused trouble until we noticed the issue. This will hopefully prevent that from happening again.