-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial proposal for Testing Events #105
Closed
Closed
Changes from 31 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
da4c015
Initial WIP version of Testing Events
olensmar fe695c1
fixes, removed queued event, added executionId
olensmar 965543f
added optional reason to finished events, loosened testCase type field
olensmar 8fc7ef2
added severity to testCase
olensmar 31e52fe
Update testing-events.md
TheBrunoLopes 2a72822
formatting and added Test Events to README.md
olensmar 2efb0d4
- testing-events updates
olensmar 9ed4181
- added trigger metadata to testCase/testSuite started events
olensmar 950efea
- fixed refs, bumped version of test events
olensmar 284458b
- fixed links to primer
olensmar 141d608
- added environment to testCase/testSuite started events and removed …
olensmar 32da41d
- added schemas and aligned vocabulary
olensmar 3c58cd5
updates in line with meeting discussion/feedback:
olensmar af33f3d
minor fixes..
olensmar 73cc269
fixed review comments:
olensmar b00eeed
review comment: changed abort to cancel
olensmar 6832877
review comments: fixed environment examples and spec errors
olensmar f1e5b55
review comments: extracted objects for testCase/testSuite, added exam…
olensmar 6a8bd2a
added examples and fixed errors
olensmar 9c86a9a
fixed linting and example errors
olensmar 0779d09
fixed linting and example errors
olensmar 69ad13c
fixed linting and example errors
olensmar 9d2f24b
added missing enum and fixed type removal
olensmar 7d1d09d
added missing object properties
olensmar 4a0111a
fixed boolean..
olensmar 833aad2
more review comments..
olensmar f6ec1b9
fixing stupid mistakes..
olensmar e9d42bd
removed descriptions
olensmar ffa8b12
updated deployment object and spec for type to include enum values
olensmar 01a40e5
updated schema version to 0.3.0-draft
olensmar 5316b76
renamed status to outcome
olensmar d38ac16
removed type from testCaseRun
olensmar aa13c88
fixed versions and outputType
olensmar 0cedc9f
Update testing-events.md
olensmar 059a9de
fixed wording
olensmar 19e1b6e
Merge branch 'main' of https://github.com/kubeshop/cdevents-spec
olensmar 8c5db20
Merge remote-tracking branch 'upstream/main'
olensmar edd9029
fixed required outcome property
olensmar 3198d17
fixed required outcome property
olensmar d0f04b0
Merge branch 'main' of https://github.com/kubeshop/cdevents-spec
olensmar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
{ | ||
"context": { | ||
"version": "0.2.0", | ||
"id": "271069a8-fc18-44f1-b38f-9d70a1695819", | ||
"source": "/event/source/123", | ||
"type": "dev.cdevents.testcaserun.finished.0.3.0-draft", | ||
"timestamp": "2023-03-20T14:27:05.315384Z" | ||
}, | ||
"subject": { | ||
"id": "myTestCaseRun123", | ||
"source": "/event/source/123", | ||
"type": "testCaseRun", | ||
"content": { | ||
"outcome" : "pass", | ||
"environment": { | ||
"id": "dev", | ||
"source": "testkube-dev-123" | ||
}, | ||
"testCase": { | ||
"id": "92834723894", | ||
"version": "1.0", | ||
"name": "Login Test", | ||
"type": "integration" | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
{ | ||
"context": { | ||
"version": "0.2.0", | ||
"id": "271069a8-fc18-44f1-b38f-9d70a1695819", | ||
"source": "/event/source/123", | ||
"type": "dev.cdevents.testcaserun.queued.0.3.0-draft", | ||
"timestamp": "2023-03-20T14:27:05.315384Z" | ||
}, | ||
"subject": { | ||
"id": "myTestCaseRun123", | ||
"source": "/event/source/123", | ||
"type": "testCaseRun", | ||
"content": { | ||
"environment": { | ||
"id": "dev", | ||
"source": "testkube-dev-123" | ||
}, | ||
"testCase": { | ||
"id": "92834723894", | ||
"version": "1.0", | ||
"name": "Login Test", | ||
"type": "integration" | ||
}, | ||
"trigger": { | ||
"type": "schedule" | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
{ | ||
"context": { | ||
"version": "0.2.0", | ||
"id": "271069a8-fc18-44f1-b38f-9d70a1695819", | ||
"source": "/event/source/123", | ||
"type": "dev.cdevents.testcaserun.started.0.3.0-draft", | ||
"timestamp": "2023-03-20T14:27:05.315384Z" | ||
}, | ||
"subject": { | ||
"id": "myTestCaseRun123", | ||
"source": "/event/source/123", | ||
"type": "testCaseRun", | ||
"content": { | ||
"environment": { | ||
"id": "dev", | ||
"source": "testkube-dev-123" | ||
}, | ||
"testCase": { | ||
"id": "92834723894", | ||
"version": "1.0", | ||
"name": "Login Test", | ||
"type": "integration" | ||
}, | ||
"trigger": { | ||
"type": "schedule" | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
{ | ||
"context": { | ||
"version": "0.2.0", | ||
"id": "271069a8-fc18-44f1-b38f-9d70a1695819", | ||
"source": "/event/source/123", | ||
"type": "dev.cdevents.testoutput.published.0.3.0-draft", | ||
"timestamp": "2023-03-20T14:27:05.315384Z" | ||
}, | ||
"subject": { | ||
"id": "testrunreport-12123", | ||
"source": "/event/source/testrunreport-12123", | ||
"type": "testOutput", | ||
"content": { | ||
"outputType" : "video", | ||
"format" : "video/quicktime", | ||
"testCaseRun": { | ||
"id": "myTestCaseRun123", | ||
"source": "testkube-dev-123" | ||
} | ||
} | ||
} | ||
} |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
{ | ||
"context": { | ||
"version": "0.2.0", | ||
"id": "271069a8-fc18-44f1-b38f-9d70a1695819", | ||
"source": "/event/source/123", | ||
"type": "dev.cdevents.testsuiterun.finished.0.3.0-draft", | ||
"timestamp": "2023-03-20T14:27:05.315384Z" | ||
}, | ||
"subject": { | ||
"id": "myTestSuiteRun123", | ||
"source": "/event/source/123", | ||
"type": "testSuiteRun", | ||
"content": { | ||
"outcome" : "fail", | ||
"severity" : "critical", | ||
"reason" : "Host 123.34.23.32 not found", | ||
"environment": { | ||
"id": "dev", | ||
"source": "testkube-dev-123" | ||
}, | ||
"testSuite": { | ||
"id": "92834723894", | ||
"version": "1.0", | ||
"name": "Auth TestSuite" | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
{ | ||
"context": { | ||
"version": "0.2.0", | ||
"id": "271069a8-fc18-44f1-b38f-9d70a1695819", | ||
"source": "/event/source/123", | ||
"type": "dev.cdevents.testsuiterun.queued.0.3.0-draft", | ||
"timestamp": "2023-03-20T14:27:05.315384Z" | ||
}, | ||
"subject": { | ||
"id": "myTestSuiteRun123", | ||
"source": "/event/source/123", | ||
"type": "testSuiteRun", | ||
"content": { | ||
"environment": { | ||
"id": "dev", | ||
"source": "testkube-dev-123" | ||
}, | ||
"testSuite": { | ||
"id": "92834723894", | ||
"version": "1.0", | ||
"name": "Auth TestSuite" | ||
}, | ||
"trigger": { | ||
"type": "pipeline" | ||
} | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The schema release we're now aiming at is 0.3.0, and therefore this version field should state "0.3.0-draft". The same comment is valid for all example files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spec version is 0.3.0, the event version is 0.1.0, so:
.context.version
should be set to0.3.0-draft
.context.type
should be reverted todev.cdevents.testsuiterun.finished.0.1.0-draft