Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kokkos makefile parser #675

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −1
Open

Fix kokkos makefile parser #675

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc3cbec
makefile output is always the last line
JBlaschke Oct 17, 2021
ea00af7
make outputs have trailing \\n -- this removes these blank lines
JBlaschke Oct 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion simtbx/kokkos/SConscript
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,10 @@ kokkos_cxxflags = subprocess.check_output(
['make', '-f', 'Makefile.kokkos', 'print-cxx-flags'],
cwd=os.environ['KOKKOS_PATH'])
kokkos_cxxflags = kokkos_cxxflags.split(b'\n')
kokkos_cxxflags = kokkos_cxxflags[1].decode('utf8').split()
# remove empty lines (this will also remove trailing \n in stdout)
kokkos_cxxflags = list(filter(lambda x: x!=b'', kokkos_cxxflags))
# last line returned by print-cxx-flags contains flags
kokkos_cxxflags = kokkos_cxxflags[-1].decode('utf8').split()
print('KOKKOS_CXXFLAGS:', kokkos_cxxflags)
print('='*79)

Expand Down