Trying to compile on gcc without warnings.

[nksauter]

Three warnings can be safety suppressed, but it would be better if
the underlying code could be fixed so no gcc warnings are generated.

[nksauter]

Would like to be able to compile all code with libtbx.scons without generating gcc warnings. These three warning suppressions are currently needed (-Wno-deprecated-declarations -Wno-maybe-uninitialized -Wno-terminate"). Initiating a conversation in the hope that the underlying code can be fixed, so that these warning suppressions aren't needed. Asking for developer review.

[graeme-winter]

@nksauter aim is to initiate conversation about underlying code issues - here you tag dials -> let's discuss.

I too would like to live in a world where our compilers did not complain at length about our code. It has never sat well with me.

What is the error?

[nksauter]

I'm specifically asking @bkpoon for information about fixing the underlying code, because I seem to remember discussing one of the warnings. I'm attaching a file showing the warnings squashed by -Wno-terminate in hope that this will restart the discussion.
terminate_squash_warns.pdf

[bkpoon]

The throw will always call terminate() should be similar to the warnings we had from fable. To fix the warnings in fable, we set the destructor to noexcept(false). We have the fable/noexcept_false.hpp header in fable to get rid of the warnings. Basically, an exception may be thrown in the destructor. In C++11, the default behavior is to not allow exceptions to be thrown in the destructor.