-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VST Chugin #47
base: main
Are you sure you want to change the base?
VST Chugin #47
Conversation
public: | ||
// add reference (ge: april 2013: made these virtual) | ||
- virtual void add_ref(); | ||
+ virtual void add_ref() {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you submit a pull request against https://github.com/ccrma/chuck so that this patch isn't necessary here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but I'm reluctant to do that because I don't know if it would have unwanted side effects.
VST/tests/vst_effect_test.ck
Outdated
@@ -0,0 +1,24 @@ | |||
"C:/VSTPlugIns/ValhallaRoom_x64.dll" => string vst_effect_path; // Must be absolute path. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there MIT-licensed VST effect(s) we could use here instead of proprietary ones?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think of the 64-bit Dimension Expander plugin here? https://xferrecords.com/freeware/ It's labeled freeware and is working with my chuck test. Would it be ok to add the DLL to the repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added the DLL in this commit 79c3e59
VST/tests/vst_instrument_test.ck
Outdated
@@ -0,0 +1,28 @@ | |||
"C:/VSTPlugIns/Serum_x64.dll" => string vst_path; // Must use absolute path. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there MIT-licensed VST instrument(s) we could use here instead of proprietary ones?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think of Tal-NoiseMaker? It's GPL and working with my test. https://tal-software.com/products/tal-noisemaker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've add the DLL in this commit 79c3e59
@DBraun sorry for the extreme delay, this looks super cool (I definitely want the same thing) but would recommend
To the last point -- there is some interest in having the ccrma/chugins repo be cross-platform and validated as generally working well for people, but also supporting community-developed chugins that don't meet all of these criteria (yet). For the latter, there is some discussion of a chuck/chugin package manager that could facilitate this. |
Agreed. I think having a projucer file is good for maintenance. This is how DawDreamer works, and it supports macOS universal builds, which I know is the main cross platform headache. I may get around to a fresh VST chugin in a few months… If anyone wants to beat me to it (please), let us know here. I can offer some guidance through DawDreamer. |
So, I have not looked into this extensively, but @dbadb has a vst3 chugin on their fork, perhaps this solves some of the issues (I don't think it does, but it's good to know what's out there) |
I've added a VST chugin.
Some notes:
vst.getParameterName(0)
). I'm working on that here How to return string in a chugin function? #46