Skip to content

Commit

Permalink
[wasm64] Remove table64 lowering by default (emscripten-core#23051)
Browse files Browse the repository at this point in the history
The engines that support memory64 now all also support table64.
  • Loading branch information
sbc100 authored Dec 3, 2024
1 parent c47a0f8 commit 1b6121d
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions tools/link.py
Original file line number Diff line number Diff line change
Expand Up @@ -2003,11 +2003,10 @@ def run_embind_gen(wasm_target, js_syms, extra_settings, linker_inputs):
# Build the flags needed by Node.js to properly run the output file.
node_args = []
if settings.MEMORY64:
node_args += shared.node_memory64_flags()
# Currently we don't have any engines that support table64 so we need
# to lower it in order to run the output.
# In the normal flow this happens later in `phase_binaryen`
building.run_wasm_opt(outfile_wasm, outfile_wasm, ['--table64-lowering'])
# The final version of memory64 proposal is not yet implement in any
# shipping version of node, so we need to lower it away in order to
# execute the binary at built time.
building.run_wasm_opt(outfile_wasm, outfile_wasm, ['--memory64-lowering', '--table64-lowering'])
if settings.WASM_EXCEPTIONS:
node_args += shared.node_exception_flags(config.NODE_JS)
# Run the generated JS file with the proper flags to generate the TypeScript bindings.
Expand Down

0 comments on commit 1b6121d

Please sign in to comment.