Add support for FreeBSD #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The patterndb module use 'installed' for ensure_resource() to make sure the package is installed. 'installed' is prefered to 'present' and using different values cause a conflict that can be avoided by this change.
FreeBSD has no root group, the wheel group is basically the equivalent for system files.
|
If I am correct, both CentOS 7 and 8 have reached EOL and we can ignore these failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been using these patches for quite some time. Time to have them upstreamed?
I think that we can also remove EOL OS from metadata.json in a few more PR and roll a new release? What do you think?