Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add mock s3 clients / mack CI uploads mock #73

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

test: add mock s3 clients / mack CI uploads mock #73

wants to merge 3 commits into from
+58 −13

Conversation

gordonkoehn
Copy link
Collaborator

@gordonkoehn gordonkoehn commented Dec 20, 2024 •
edited
Loading

This PR addresses

@gordonkoehn gordonkoehn self-assigned this Dec 20, 2024
@gordonkoehn gordonkoehn added enhancement New feature or request refactor and removed enhancement New feature or request labels Dec 20, 2024
@gordonkoehn gordonkoehn marked this pull request as ready for review December 20, 2024 15:57
@Copilot Copilot bot review requested due to automatic review settings December 20, 2024 15:57
Copilot
Copilot AI reviewed Dec 20, 2024
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

src/sr2silo/s3.py
import shutil
from pathlib import Path

import boto3
from botocore.exceptions import NoCredentialsError
from moto import mock_aws
Copy link
Preview

Copilot AI Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import should be 'from moto import mock_s3' instead of 'from moto import mock_aws'.

Suggested change
from moto import mock_aws
from moto import mock_s3

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
@gordonkoehn
Copy link
Collaborator Author

The container fails wiht core sr2silo_sr2silo_1 exited with code 1 and just does not run.

this should fail

implements this !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Copilot left review comments

At least 0 approving reviews are required to merge this pull request.

Assignees

@gordonkoehn gordonkoehn

Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gordonkoehn