Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: v-pipe to silo transformer script #24

Merged
merged 20 commits into from
Nov 18, 2024
Merged

Conversation

gordonkoehn
Copy link
Collaborator

This PR builds the first version of the translation script to go from V-Pipe actual outputs to the amino acids in an orderly manner.

@gordonkoehn gordonkoehn self-assigned this Nov 13, 2024
@gordonkoehn gordonkoehn marked this pull request as draft November 13, 2024 13:22
@gordonkoehn gordonkoehn added the enhancement New feature or request label Nov 13, 2024
@gordonkoehn gordonkoehn marked this pull request as ready for review November 14, 2024 15:27
@gordonkoehn gordonkoehn requested a review from Taepper November 14, 2024 15:29
Copy link
Collaborator Author

@gordonkoehn gordonkoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaning up the current state after today's session together.

Wrapped up a first draft of the process_directory function. A full set of metadata is now generated.

See a few quick comments below. Nothing major, feel free to ignore / resolve all comments.

Merge at will, no review needed - just FYI.

scripts/vp_transformer.py Show resolved Hide resolved
scripts/vp_transformer_config.json Show resolved Hide resolved
tests/test_scripts.py Show resolved Hide resolved
tests/test_scripts.py Show resolved Hide resolved
tests/test_scripts.py Show resolved Hide resolved
tests/test_scripts_dgicev.py Show resolved Hide resolved
@gordonkoehn gordonkoehn merged commit bf374b7 into main Nov 18, 2024
1 check passed
@gordonkoehn gordonkoehn deleted the feature/vpipe_transformer branch November 21, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants