Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Upload to Test S3 upload, not real AWS #72

Open
Tracked by #62
gordonkoehn opened this issue Dec 20, 2024 · 1 comment
Open
Tracked by #62

Change Upload to Test S3 upload, not real AWS #72

gordonkoehn opened this issue Dec 20, 2024 · 1 comment
Assignees
Labels

Comments

@gordonkoehn
Copy link
Collaborator

gordonkoehn commented Dec 20, 2024

Currently, even in testing in the CI, there is an actual S3 upload happening.

This should not be the case.

Let's implement some s3 test framework.

And activate it in the tests.

As well as write unit tests for the s3 functions implemented.

@gordonkoehn gordonkoehn changed the title Change Upload to Test S3 upload, not to my actual AWS Change Upload to Test S3 upload, not real AWS Dec 20, 2024
@gordonkoehn gordonkoehn self-assigned this Dec 20, 2024
@gordonkoehn
Copy link
Collaborator Author

gordonkoehn commented Dec 20, 2024

sr2silo_1  | Traceback (most recent call last):
sr2silo_1  |   File "/app/scripts/vp_transformer.py", line 19, in <module>
sr2silo_1  |     from sr2silo.s3 import compress_bz2, upload_file_to_s3
sr2silo_1  |   File "/app/src/sr2silo/s3.py", line 13, in <module>
sr2silo_1  |     from moto import mock_aws
sr2silo_1  | ModuleNotFoundError: No module named 'moto'
sr2silo_sr2silo_1 exited with code 1
Removing sr2silo_sr2silo_1 ... 
Removing sr2silo_sr2silo_1 ... done
Removing network sr2silo_default

This is in docker test.

It should fail but it does not.

Once it properly fails add moto.

Probably moto is not found as it is installed as a dev dependency.

Not sure if this makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant