Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating Relative Amplicon Coverage #9

Merged
merged 54 commits into from
Sep 24, 2024
Merged

Integrating Relative Amplicon Coverage #9

merged 54 commits into from
Sep 24, 2024

Conversation

gordonkoehn
Copy link
Collaborator

@gordonkoehn gordonkoehn commented Sep 12, 2024

This PR attempts to integrate the following script into this installable package such that it may, in the future, be easily integrated into V-Pipe.

Amplicon Coverage Test

Integrating this into V-Pipe will allow others using the pipeline to profit from this quality check.

This PRs main objective was to:

  • implement a Snakemake workflow for per batch generation of coverage_heatmaps

further this PR improved code quality by:

  • replace argparse with click
  • reformated to black and ruff standards
  • adds some typing and explanatory comments

Considerations:

  • consider using click instead of argparse (Ivan)
  • Make one Snakemake rule per batch (Ivan / Matteo)
  • Remove Unused Plotting functions for a clean code base - confirmed with Matteo

Open Questions:

  • Some of the plotting functions originally commented out are - I left commented out. Are they needed? make_median_cov_hist, make_median_coverage_barplot, ...

@gordonkoehn gordonkoehn self-assigned this Sep 12, 2024
@gordonkoehn
Copy link
Collaborator Author

I can currently run and reproduce the plots. Given the test_data from Matteo.

@gordonkoehn gordonkoehn added enhancement New feature or request labels Sep 12, 2024
@gordonkoehn
Copy link
Collaborator Author

The script works per batch now. :) With Snakemake Rules per Batch :) Some clean up still pending.

@gordonkoehn
Copy link
Collaborator Author

NB: I activated all commented-out plots. This may not be needed.

  • check with Matteo / David

@gordonkoehn gordonkoehn merged commit 7fd3531 into main Sep 24, 2024
1 of 2 checks passed
@gordonkoehn gordonkoehn deleted the amplion_cov branch September 24, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant