Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-export SYSTEMATIC_INDICES_AND_PARAMETERS constant #167

Closed
wants to merge 1 commit into from

Conversation

mlegner
Copy link
Contributor

@mlegner mlegner commented Apr 10, 2024

This constant may be interesting for consumers of this library. For example, to choose a number of source symbols that does not require padding symbols.

This constant may be interesting for consumers of this library. For example, to choose a number of source symbols that does not require padding symbols.
@cberner
Copy link
Owner

cberner commented Apr 12, 2024

I don't think I want to expose this, but feel free to send a PR for a helper function(s) that does those calculations

@mlegner
Copy link
Contributor Author

mlegner commented Apr 12, 2024

I don't think I want to expose this, but feel free to send a PR for a helper function(s) that does those calculations

OK, I'll look into it. Maybe something like closest_n_source_symbols_without_padding(target: u16), with variants for "closest above" and "closest below".

@mlegner
Copy link
Contributor Author

mlegner commented Apr 17, 2024

Actually, we changed our approach and don't currently need this. I will close this PR for now. Sorry for the noise.

@mlegner mlegner closed this Apr 17, 2024
@mlegner mlegner deleted the patch-1 branch April 17, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants