ready for resubmission 0.4.1

cb4ds · Mar 5, 2019 · ef7f31e · ef7f31e
1 parent dccfe80
commit ef7f31e
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 13 deletions.
diff --git a/R/generate_template.R b/R/generate_template.R
@@ -82,7 +82,7 @@
 #' create_new_application(name = 'mytestapp', location = tempdir())
 #'
 #' @export
-create_new_application <- function(name, location = ".", sampleapp = FALSE) {
+create_new_application <- function(name, location, sampleapp = FALSE) {
     usersep <- .Platform$file.sep
     newloc <- paste(location, name, sep = usersep)
 

diff --git a/README.md b/README.md
@@ -39,7 +39,7 @@ These are included to get you started. You can either start with an empty applic
 
 ```r
 library(periscope)
-create_new_application('emptyapp')
+create_new_application('emptyapp', location = tempdir())
 runApp('emptyapp')
 ```
 
@@ -48,7 +48,7 @@ runApp('emptyapp')
 
 ```r
 library(periscope)
-create_new_application("sampleapp", sampleapp = TRUE)
+create_new_application("sampleapp", location = tempdir(), sampleapp = TRUE)
 runApp('sampleapp')
 
 ```

diff --git a/cran-comments.md b/cran-comments.md
@@ -2,11 +2,12 @@
 
 This is the initial release for this package to CRAN, and due to this there is a package build NOTE on rhub and win-builder builds about this being a new package release.
 
-Update the package per initial crann comments:
+Update the package per initial CRAN submission comments:
 
 * single-quoted proper names in Title & Description
 * added executables to the man (Rd) documentation
-* updated tests vignettes and examples to use tempdir() when creating new applications and running tests
+* updated package to NOT have a default filesystem location when creating a new templated application
+* updated tests vignettes & examples to use tempdir()
 
 ---  
 

diff --git a/man/create_new_application.Rd b/man/create_new_application.Rd
diff --git a/tests/testthat/test_create_new_application.R b/tests/testthat/test_create_new_application.R
@@ -53,7 +53,7 @@ test_that("create_new_application sample", {
 })
 
 test_that("create_new_application invalid location", {
-    expect_warning(create_new_application(name = "SOinvalid", location = tempfile(), sampleapp = FALSE),
+    expect_warning(create_new_application(name = "Invalid", location = tempfile(), sampleapp = FALSE),
                    "Framework creation could not proceed, location=.* does not exist!")
 })
 

diff --git a/vignettes/new-application.Rmd b/vignettes/new-application.Rmd
@@ -175,9 +175,6 @@ create_new_application(name = 'mytestapp', location = app_dir, sampleapp = TRUE)
 This generates a default sample application in a subdirectory named *mytestapp* 
 at the specified location.  The location must exist when calling this function.
 
-The location parameter defaults to '.', which means if you leave off this parameter
-the application will be created in the current R directory.
-
 *Note*: If the *mytestapp* directory in this location already exists it will not 
 be overwritten - the function will give a warning and exit without modifying the 
 user's system.
@@ -208,9 +205,6 @@ create_new_application(name = 'mytestapp', location = app_dir)
 This generates a default blank application in a subdirectory named *mytestapp* 
 at the specified location.  The location must exist when calling this function.
 
-The location parameter defaults to '.', which means if you leave off this parameter
-the application will be created in the current R directory.
-
 *Note*: If the *mytestapp* directory in this location already exists it will not
 be overwritten - the function will give a warning and exit without modifying the 
 user's system.