clean up ci #35
Merged
clean up ci #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorel-35
force-pushed
the
cleanup-ci
branch
6 times, most recently
from
ea833d1
to
c4c6961
Compare
alexandear
reviewed
Nov 20, 2024
mmorel-35
force-pushed
the
cleanup-ci
branch
from
c4c6961
to
12b695a
Compare
alexandear
approved these changes
Nov 20, 2024
mmorel-35
force-pushed
the
cleanup-ci
branch
from
12b695a
to
87ea608
Compare
mmorel-35
force-pushed
the
cleanup-ci
branch
from
87ea608
to
694596c
Compare
alexandear
approved these changes
Nov 20, 2024
ccoVeille
reviewed
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR clean up the ci workflow
It uses GitHub action instead of manual install for golangci lint and use it to define the golangci lint version used.
It uses setup go option to read from go.mod file the golang version instead of environment variable
It uses explicitly the make targets that are uses in the workflow