-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft] Make dynamic tables expandable #1137
base: main
Are you sure you want to change the base?
Conversation
for column in dynamic_table.columns: | ||
candidate_dataset = column.data # VectorData object | ||
dynamic_table = neurodata_object # For readability | ||
for column in (*dynamic_table.columns, dynamic_table.id): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, we add the ids of the tables to the set that we catch for setting the DataIO.
@@ -119,16 +119,14 @@ def get_default_dataset_io_configurations( | |||
continue # Skip | |||
|
|||
# Skip over columns whose values are links, such as the 'group' of an ElectrodesTable | |||
if any(isinstance(value, Container) for value in candidate_dataset): | |||
continue # Skip | |||
# if any(isinstance(value, Container) for value in candidate_dataset): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I commented this because this was catching the ElectrodeGroups column. There is probably a better way.
Sup, @bendichter I wanted to write this here so we have an anchor point for discussion next time we meet. Taking the electrodes table as a starting point there are two objects that we are not catching for chunkg at the moment:
Check the code below for more comments but the gist of where I got stuck is here:
For the ids, the data was chunk but the maxshape was also so it becomes non-expandable.
Important, note that for hdf5 we only pass chunk to the DataIO:
https://github.com/catalystneuro/neuroconv/blob/df9d6f84a70f0840d78c09c42dd6e67afd24ff3c/src/neuroconv/tools/nwb_helpers/_configuration_models/_zarr_dataset_io.py#L132-L133