Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#433] Update factor email tests #434

Merged
merged 1 commit into from
Aug 31, 2023
Merged

[#433] Update factor email tests #434

merged 1 commit into from
Aug 31, 2023

Conversation

matthewhilton
Copy link
Collaborator

@matthewhilton matthewhilton commented Aug 31, 2023 •
edited
Loading

Closes #433

  • Tests now just check if either an Unknown location message or actual location message existed.
  • This still works as a test, because it checks that no exceptions were thrown
  • Using strpos so that it can just be cherry-picked to the other branches without changing (php version compatibility)

@matthewhilton matthewhilton mentioned this pull request Aug 31, 2023
Merged
@matthewhilton matthewhilton changed the title [#443] Update factor email tests [#433] Update factor email tests Aug 31, 2023
@matthewhilton matthewhilton force-pushed the fix-email-factor-tests-400 branch from 83649aa to 469452d Compare August 31, 2023 22:37
@Peterburnett Peterburnett merged commit 772bb25 into MOODLE_400_STABLE Aug 31, 2023
13 checks passed
@Peterburnett Peterburnett deleted the fix-email-factor-tests-400 branch August 31, 2023 22:59
@catalystfd catalystfd mentioned this pull request Feb 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Email factor unit test failures
2 participants
@matthewhilton @Peterburnett