Skip to content

Commit

Permalink
[#272] Make code checker and phpdoc happy
Browse files Browse the repository at this point in the history
  • Loading branch information
Fragonite committed Sep 5, 2023
1 parent dcc74e5 commit e11dbf3
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 6 deletions.
6 changes: 3 additions & 3 deletions classes/script_metadata.php
Original file line number Diff line number Diff line change
Expand Up @@ -226,9 +226,9 @@ public static function get_request(): string {

/**
* Gets the name of the script.
* Parameters are share the names of globals as a hint to the caller.
* @param string $ME
* @param string $SCRIPT
* Parameters share the names of globals as a hint to the caller.
* @param ?string $ME
* @param ?string $SCRIPT
* @return string the request path for this profile.
*/
public static function get_normalised_relative_script_path(?string $ME, ?string $SCRIPT): string {
Expand Down
10 changes: 7 additions & 3 deletions tests/tool_excimer_script_metadata_test.php
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,9 @@ public function sampling_limit_provider(): array {
* Tests script_metadata::get_request().
* @dataProvider normalised_relative_script_path_provider
* @covers \tool_excimer\script_metadata::get_request
* @param string $path
* @param string $oldexpected
* @param string $newexpected
*/
public function test_get_request(string $path, string $oldexpected, string $newexpected) {
script_metadata::init();
Expand All @@ -213,8 +216,9 @@ public function test_get_request(string $path, string $oldexpected, string $newe
* Tests script_metadata::get_normalised_relative_script_path().
* @dataProvider normalised_relative_script_path_provider
* @covers \tool_excimer\script_metadata::get_normalised_relative_script_path
* @param string $pathinfo
* @param string $expected
* @param string $path
* @param string $oldexpected
* @param string $newexpected
*/
public function test_get_normalised_relative_script_path(string $path, string $oldexpected, string $newexpected) {
script_metadata::init();
Expand All @@ -224,7 +228,7 @@ public function test_get_normalised_relative_script_path(string $path, string $o

/**
* Provider for test_get_normalised_relative_script_path().
* @return \string[][]
* @return array[]
*/
public function normalised_relative_script_path_provider(): array {
return [
Expand Down

0 comments on commit e11dbf3

Please sign in to comment.