Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moodle 401 stable 853 historyfix #854

Merged
merged 2 commits into from
Dec 22, 2023
Merged

Moodle 401 stable 853 historyfix #854

merged 2 commits into from
Dec 22, 2023

Conversation

marcghaly
Copy link
Contributor

Hi @keevan,

This PR fixes issue #853, 2 commits have been cherry-picked.

Regards,

Marc-A

@marcghaly marcghaly added the bug Something isn't working label Dec 5, 2023
@marcghaly marcghaly self-assigned this Dec 5, 2023
@keevan keevan enabled auto-merge December 5, 2023 04:18
@marcghaly marcghaly requested a review from keevan December 5, 2023 05:28
@marcghaly
Copy link
Contributor Author

marcghaly commented Dec 8, 2023 •
edited
Loading

Hi @keevan,

We are getting timeouts on ci / cd for PHP 8.1, this seems to be related with Symfony's use of the ctype_digit method, I have looked at different functions that could be used however they are not exactly similar - cf
image

cf : #851

If I am not mistaken the version in the project is 4.4.50 - I am not sure if there are any downsides to updating the library to something higher - it seems that Symfony 6.1 will require PHP 8.1.

Regards,

Marc-Alexandre

@marcghaly marcghaly force-pushed the MOODLE_401_STABLE-853-historyfix branch 3 times, most recently from 8442071 to b174f51 Compare December 19, 2023 06:22
@marcghaly
Copy link
Contributor Author

marcghaly commented Dec 19, 2023 •
edited
Loading

Hi @keevan, I have updated supported versions and ci setting - do we need a requirement for 35 and 400 to pass ci on this branch ?

@marcghaly marcghaly requested review from Peterburnett and keevan and removed request for keevan and Peterburnett December 19, 2023 22:36
@marcghaly marcghaly force-pushed the MOODLE_401_STABLE-853-historyfix branch from cb6e185 to 568a142 Compare December 22, 2023 04:29
@marcghaly
Copy link
Contributor Author

Issue #853 should be resolved with latest version bump, rebased, this PR brings min php version to 7.4 for ci + readme update and supported moodle version,

Regards,

Marc-A.

@keevan keevan merged commit 72003f5 into MOODLE_401_STABLE Dec 22, 2023
10 checks passed
@keevan keevan deleted the MOODLE_401_STABLE-853-historyfix branch December 22, 2023 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keevan keevan keevan approved these changes

@Peterburnett Peterburnett Awaiting requested review from Peterburnett

Assignees

@marcghaly marcghaly

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcghaly @keevan