Produce summary data to feed back into --table option and clean up #13
Conversation
tuanngocnguyen
force-pushed
the
summary_output
branch
from
dd52eee to
5e86d5f
Compare
tuanngocnguyen
changed the title
tuanngocnguyen
force-pushed
the
summary_output
branch
2 times, most recently
from
d1a256c to
a161615
Compare
tuanngocnguyen
force-pushed
the
summary_output
branch
3 times, most recently
from
7724b98 to
bc2b345
Compare
classes/helper.php
Outdated
| $record = $DB->get_record($table, ['id' => $id], $column); | ||
|
|
||
| // Replace the text. | ||
| $text = str_replace($match, $replace, $record->$column); |
There was a problem hiding this comment.
pros and cons of using $DB->replace_all_text ? I assume using it will be faster and reduce the DB io quite a lot.
There was a problem hiding this comment.
ah, we can't use this because we can't pass in a where clause to limit it to 1 id. But I think we should clone this function and add the filter, and make a not when we go back to upstream this into core to combine this back ine
tuanngocnguyen
force-pushed
the
summary_output
branch
from
bc2b345 to
b85e8d0
Compare
| fclose($fp); | ||
|
|
||
| if ($summary) { | ||
| // Read the content of the output file. |
There was a problem hiding this comment.
this all looks weird to me, whats the reason for this? we really don't want to touch the file a second time and we definitely don't want to load it all into memory at once
tuanngocnguyen
force-pushed
the
summary_output
branch
from
b85e8d0 to
eef87a9
Compare
tuanngocnguyen
changed the title
| @@ -330,8 +334,7 @@ public static function regular_expression_search(string $search, string $table, | |||
| if (!empty($stream)) { | |||
| if ($summary) { | |||
| fputcsv($stream, [ | |||
| $table, | |||
| $column->name, | |||
| "$table:$column->name", | |||
There was a problem hiding this comment.
why did you combine these?
|
Hi @brendanheywood , I have created new PR for clean up commit. |
No description provided.