Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nvm workaround #124

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Nvm workaround #124

merged 2 commits into from
Aug 19, 2024

Conversation

matthewhilton
Copy link
Contributor

@matthewhilton matthewhilton commented Aug 19, 2024

It has been over a week since the latest nvm 0.40 started breaking pipelines.
While it would be ideal to wait, we can't wait forever.
I don't see any issue downgrading, this this isn't downgrading node just downgrading the version manager.

Testing
Using catalyst/moodle-mod_hvp#58 as the test to confirm the updated branch works -> https://github.com/catalyst/moodle-mod_hvp/actions/runs/10446880888/job/28924957408

Confirmed under top Set up job it uses the commit here e213f3106d307bd02f484be0ca11e21d939f1ef7 as the workflow
image

Confirmed it successfully installs moodle plugin CI + gets up to unit tests
image

Once happy with this before merging I will remove 6fa1abc - I didn't find a way to do this automatically in the PR commits

@matthewhilton matthewhilton marked this pull request as draft August 19, 2024 04:04
Copy link
Contributor

@keevan keevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we actually remove the group-XX-to-XX changes from this PR and just delete them in a separate PR? The single ci.yml should replace all those ci files.

Copy link
Contributor

@keevan keevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the changes otherwise (seems like others are also implementing the workaround like so).

Thanks Matt.

@matthewhilton
Copy link
Contributor Author

matthewhilton commented Aug 19, 2024

Could we actually remove the group-XX-to-XX changes from this PR and just delete them in a separate PR? The single ci.yml should replace all those ci files.

Are these files not necessary? I found via testing it was calling on them hence why I had to change them, but maybe that was just a coincidence ?

Edit: #119 I think might be referenced. Will leave as-is since this is what has been tested, but in future we can probably just nuke those files.

@matthewhilton matthewhilton marked this pull request as ready for review August 19, 2024 04:14
@matthewhilton matthewhilton merged commit b9b6132 into main Aug 19, 2024
@matthewhilton matthewhilton deleted the nvm-workaround branch August 19, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reference other workflows via paths, not branch / git links. NodeJS install failure
2 participants