Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with pydantic >=1.10, <3 #7

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

RobertoMaurizzi
Copy link

Again simple PR to relax the dependency on Pydantic to <3
Tested only with Bilum, if using getter_dict override it'll need work (and it'll fail silently, I need to add...)

@RobertoMaurizzi
Copy link
Author

It does look we need updates here to have full compatibility for Pydantic 2.
I recreated the lock file with --no-update but now the action fails because it can't connect to Postgres... I guess GitHub is having some trouble today

@RobertoMaurizzi
Copy link
Author

RobertoMaurizzi commented Oct 4, 2024

Update: tests pass locally with a container that's pretty much the same as the one used in the workflow file... also, what's special about the catalpaio/dird_test postgres image we use in Bilum?

@joshbrooks
Copy link
Collaborator

Ooh, good question!
The catalpaio/dird_test postgres image ought to be better documented!
This is an image with most migrations already run - it shaves significant time off the test run. However it's a couple of years old now so it would be good to update it

@joshbrooks
Copy link
Collaborator

I'll take a look at the test failures here and see if we can get past them
It looks like those are not related to your changes

Set the port to same as settings
@@ -67,4 +67,4 @@ jobs:
--health-timeout 5s
--health-retries 5
ports:
- 49156:5432
- 49155:5432
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.. i really need to get into the habit to ALWAYS wear glasses when I'm at the computer 😩

@RobertoMaurizzi
Copy link
Author

@joshbrooks do we merge? 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants