-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with pydantic >=1.10, <3 #7
base: main
Are you sure you want to change the base?
Conversation
4178a7c
to
ed0060d
Compare
ed0060d
to
b245e56
Compare
It does look we need updates here to have full compatibility for Pydantic 2. |
Update: tests pass locally with a container that's pretty much the same as the one used in the workflow file... also, what's special about the |
Ooh, good question! |
I'll take a look at the test failures here and see if we can get past them |
Set the port to same as settings
@@ -67,4 +67,4 @@ jobs: | |||
--health-timeout 5s | |||
--health-retries 5 | |||
ports: | |||
- 49156:5432 | |||
- 49155:5432 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.. i really need to get into the habit to ALWAYS wear glasses when I'm at the computer 😩
@joshbrooks do we merge? 😅 |
Again simple PR to relax the dependency on Pydantic to <3
Tested only with Bilum, if using
getter_dict
override it'll need work (and it'll fail silently, I need to add...)