Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub actions #655

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Toxantron
Copy link

@Toxantron Toxantron commented Jul 20, 2023

I took the relevant changes from #641 about GitHub actions and combined them with the actions from Castle Core.

Right now I am having an issue with exit code 1 caused by test projects not availabe for a certain framework version.

@jonorossi jonorossi marked this pull request as draft July 20, 2023 13:06
@jonorossi
Copy link
Member

@Toxantron I've marked your pull request draft. I've added a Gmail filter to star Castle tickets so they don't get lost in my inbox, but mention me if I don't respond in a couple of days.

@Toxantron Toxantron force-pushed the github-actions branch 13 times, most recently from 31cc0a8 to d9cf6c6 Compare July 21, 2023 09:00
@Toxantron
Copy link
Author

@jonorossi I completed the action scripts for Windows and Linux. On Linux we run everything for net6.0 and on windows the net462 tests only. The successful runs and unit tests you can find here.

I kept the release script from @renemadsen and cleaned it up a little bit, but it is basically untested.

Let me know, what you think.

@Toxantron Toxantron marked this pull request as ready for review July 21, 2023 09:48
@Toxantron
Copy link
Author

@jonorossi do you need anything else to merge this? I could test the release script under a different ID on our myget feed, still would not garantuee correct behavior for upstream.

With this being merged we could at least disable AppVeyor CI runs.

@jonorossi
Copy link
Member

I've added a couple review comments. If you can get packages published to GitHub Packages I'll take a detailed look at the output to confirm they are what I expect.

@Toxantron Toxantron force-pushed the github-actions branch 3 times, most recently from b0dc885 to c4caffa Compare July 27, 2023 11:00
@Toxantron
Copy link
Author

I confirmed the release pipeline works and I have created packages for tags.

However using GITHUB_TOKEN causes issues when pushing multiple packages for the first time. Rerunning the same job creates the missing packages. Since we rebuild anyways this does not even cause issues with expired artifacts.

@jonorossi
Copy link
Member

jonorossi commented Jul 27, 2023

The AppVeyor package feed is for CI builds (i.e. every build), you don't have to tag them. See the readme:
https://github.com/castleproject/Windsor#nuget-preview-feed

Maybe we don't really need it anymore, and we should just tag pre-release packages more often publishing betas to nuget.org.

Since you've got that publishing working, leave it for now. I don't have time tonight to look at the package contents but I'll get to it over the next day or two, it's a great test for publishing to nuget.org from tags!

@Toxantron
Copy link
Author

We could have both. Push CI packages to GitHub after every merge on main and push to nuget.org for tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants