Add GZIP compression to collector endpoint #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivaka
force-pushed
the
REP-597/add-compression-to-collector
branch
from
0ed08ca
to
a8db5e4
Compare
Ivaka
force-pushed
the
REP-597/add-compression-to-collector
branch
from
a8db5e4
to
6a9320c
Compare
dariuspie
reviewed
Jan 25, 2024
Ivaka
force-pushed
the
REP-597/add-compression-to-collector
branch
from
ef49d1b
to
d260baf
Compare
zolinas
approved these changes
Jan 26, 2024
| @@ -154,6 +170,32 @@ func (c *Collector) GetRawNetworkMetricsHandler(w http.ResponseWriter, req *http | |||
| } | |||
| } | |||
|
|
|||
| func (c *Collector) writeGzipBody(w http.ResponseWriter, body []byte) error { | |||
| writer, err := gzip.NewWriterLevel(w, gzip.BestCompression) | |||
| if err != nil { | |||
There was a problem hiding this comment.
NIT: It's probably not worth checking the error in this case.
The error returned will be nil if the level is valid.
Ivaka
force-pushed
the
REP-597/add-compression-to-collector
branch
from
d260baf
to
dd964e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.