Fixed bug which caused calling entry points for smart contracts deplo… #4969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yed as "Transaction::Deploy" (or created in v1.x) to always fail. The fix involves changing the way we fetch entry point data in DataAccessLayer. If entry point is not found under Key::EntryPoint we fallback to see if there is a contract entry for the given contract hash. If a Contract entry exists, we query it's `entry_points` field
| fn entry_point(&self, request: EntryPointsRequest) -> EntryPointsResult { | ||
| let state_hash = request.state_hash(); | ||
| let query_request = QueryRequest::new(state_hash, request.key(), vec![]); | ||
| fn entry_point(&self, request: EntryPointsRequest) -> EntryPointResult { |
There was a problem hiding this comment.
Seems like if you are going to rename result to singular, you should rename request to singular to match.
EdHastingsCasperAssociation
approved these changes
Nov 20, 2024
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| /// Gets an entry point value. | ||
| fn entry_point_exists(&self, request: EntryPointsRequest) -> EntryPointExistsResult { |
There was a problem hiding this comment.
I acknowledge that it does work to re-use EntryPointsRequest here, but to the best of my knowledge we have kept 1:1 parity between request and response pairs (though I could be wrong). Thus I would think we would do one of the following:
- have an EntryPointExistsRequest corresponding to EntryPointExistsResponse to adhere to the request / response isomorphism convention.
- instead of adding EntryPointExistsResponse, add a variant to EntryPointResponse to handle the exists result, and modify EntryPointRequest to have a bool existence_check indicating the caller only wants t/f and does not want the entry point instance.
|
bors r+ |
|
Build succeeded: |
casperlabs-bors-ng
bot
merged commit 843b19e
into
casper-network:feat-2.0
3 checks passed
|
Related issue is #4959 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…yed as "Transaction::Deploy" (or created in v1.x) to always fail. The fix involves changing the way we fetch entry point data in DataAccessLayer. If entry point is not found under Key::EntryPoint we fallback to see if there is a contract entry for the given contract hash. If a Contract entry exists, we query it's
entry_pointsfield.