Reject transactions for which there’s no chance for the chain to reach the required gas price #4820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
July 31, 2024 11:13
|
bors try |
tryBuild succeeded: |
added 14 commits
August 9, 2024 15:19
|
bors try |
tryBuild succeeded: |
rafal-ch
changed the title
| /// Returns the gas price for the upcoming era (if this is a switch block). | ||
| pub fn next_era_gas_price(&self) -> Option<u8> { | ||
| match self { | ||
| BlockHeader::V1(_) => None, |
There was a problem hiding this comment.
this could just be 1
|
Moving it back to backlog |
|
After some back and forth deliberation, we decided to not include this in 2.0 rel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds another check to the transaction acceptor.
It makes the acceptor reject transactions with gas price tolerance set to a value that is not achievable by the chain within the given TTL.
Calculation is based on the assumptions that chain gas price can only go up and down by 1 every each era.
Additionally, this PR also fixes the problem with the gas price being reset after the network upgrade. With the fix, the gas price is preserved across the upgrades, which is covered by a new NCTL upgrade test in the corresponding PR.