Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/249 - Fixes for byte serialisation of CLValues type when nested in collection types such as maps and lists etc #250

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

meywood
Copy link
Collaborator

@meywood meywood commented Mar 4, 2024

Refactored so that the values bytes do not include the bytes of any parent value. Code has been changed to ensure each value have it's own SerializationBuffer that is used to provide its own bytes.

@meywood meywood linked an issue Mar 4, 2024 that may be closed by this pull request
@meywood meywood requested a review from cnorburn March 4, 2024 13:32
@meywood meywood changed the title Issues/249 - Fixes for byte serialisation of CLValues type when nested in collection types such as maps and lists etc Issues/249 - *** DON'T MEREGE YET *** Fixes for byte serialisation of CLValues type when nested in collection types such as maps and lists etc Mar 4, 2024
@meywood meywood changed the title Issues/249 - *** DON'T MEREGE YET *** Fixes for byte serialisation of CLValues type when nested in collection types such as maps and lists etc Issues/249 - Fixes for byte serialisation of CLValues type when nested in collection types such as maps and lists etc Mar 6, 2024
@cnorburn cnorburn merged commit 907f6af into main Mar 7, 2024
1 check passed
@cnorburn cnorburn deleted the issues/249 branch March 7, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

CLValueMap {"ONE": 2} deserialised key value contains length of map
3 participants