Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues/228 - Nested Tuples Test #229

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Issues/228 - Nested Tuples Test #229

merged 4 commits into from
Oct 31, 2023

Conversation

meywood
Copy link
Collaborator

@meywood meywood commented Oct 25, 2023

No description provided.

@meywood meywood requested a review from cnorburn October 25, 2023 16:19
@meywood meywood changed the base branch from main to issues/216 October 25, 2023 16:19
@meywood meywood linked an issue Oct 30, 2023 that may be closed by this pull request
nested tuples e2e test #228
Closed
This was referenced Oct 30, 2023
Open
Open
@meywood meywood linked an issue Oct 30, 2023 that may be closed by this pull request
CLMap complex scenarios for nested maps and Any types stormeye2000/cspr-sdk-standard-tests-java#115
Open
@meywood meywood mentioned this pull request Oct 31, 2023
Merged
@meywood
Copy link
Collaborator Author

meywood commented Oct 31, 2023

Please also review the test resources in casper-network/sdk-std-test-resources#8

stormeye2000
stormeye2000 reviewed Oct 31, 2023
View reviewed changes
Copy link
Contributor

@stormeye2000 stormeye2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move the private methods to the end of the class

@cnorburn cnorburn merged commit de15ceb into issues/216 Oct 31, 2023
@cnorburn cnorburn deleted the issues/228 branch October 31, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stormeye2000 stormeye2000 stormeye2000 approved these changes

@cnorburn cnorburn Awaiting requested review from cnorburn

Assignees
No one assigned
Labels
None yet
Projects
Work In Progress
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLMap complex scenarios for nested maps and Any types nested tuples e2e test
3 participants
@meywood @stormeye2000 @cnorburn