use a hash for metadata lock name #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prudhvi
reviewed
Dec 3, 2024
| if err = getLock(); err != nil { | ||
| return nil, err | ||
| } | ||
| logger.Infof("acquired metadata lock: %s", lockName) | ||
| logger.Infof("acquired metadata lock: %s.%s", table.SchemaName, table.TableName) |
There was a problem hiding this comment.
May be worth logging lockName too in one of the logs somewhere
There was a problem hiding this comment.
It's not easy to do that, because I'm computing the lock name server-side inside the GET_LOCK function call. So for now let's leave it like this and if in the future we have a real need to log the lock name, I think we could just add another MySQL round-trip to compute the lock name and then use it in GET_LOCK.
prudhvi
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, metadata locks would conflict across same-named tables in different schemas. This PR fixes that issue by using a combination of schema name, table name, and a hash value for the metadata lock name.