Add accessibility identifier in AccessibilityMarker #228
Conversation
priip
force-pushed
the
priip/add-identifier-in-accessibility-marker
branch
from
dcb06e4
to
1e86122
Compare
| var identifier: String? { | ||
| if let accessibilityIdentifier = value(forKey: "accessibilityIdentifier") as? String { | ||
| return accessibilityIdentifier | ||
| } | ||
| return nil | ||
| } |
There was a problem hiding this comment.
There is no "clean" way to access the accessibilityIdentifier for an NSObject, since it's only available for objects that conform to UIAccessibilityIdentification (doc) I tried using the accessibilityIdentifierBlock (doc), but that yielded no results, so I've opted to pull the value using key values. I'm open to suggestions though if ya'll have any!
There was a problem hiding this comment.
Would the following work?
if let typedSelf = self as? UIAccessibilityIdentification {
return typedSelf.accessibilityIdentifier
}
There was a problem hiding this comment.
I tried this, but it was not triggering any of the UIKIt views.
There was a problem hiding this comment.
Ugh, okay yes I vaguely remember now having a discussion with @RoyalPineapple about something very similar. I forget the context, but perhaps he can recall what he ended up doing here.
There was a problem hiding this comment.
I think the solution here of testing for known conformance before using the key/value as a fallback works well enough. This bug is frustrating every time it comes up.
priip
force-pushed
the
priip/add-identifier-in-accessibility-marker
branch
from
1e86122
to
24b20ed
Compare
| @@ -714,7 +720,7 @@ extension UIView { | |||
| fileprivate extension NSObject { | |||
| var customContent: [(label: String, value: String, isImportant:Bool)] { | |||
| // Github runs tests on specific iOS versions against specific versions of Xcode in CI. | |||
| // Forward deployment on old versions of Xcode require a compile time check which require diferentiation by swift version rather than iOS SDK. | |||
| // Forward deployment on old versions of Xcode require a compile time check which require differentiation by swift version rather than iOS SDK. | |||
Adds a new
identifierproperty to theAccessibilityMarkerobject which stores theaccessibilityIdentifierfor an element. This unique identifier can be used for identifying elements in UITests and is not visible to users.