Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for keyboard key accessibility trait #227

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support for keyboard key accessibility trait #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
779eee1
Add support for keyboard key accessibility trait
meherkasam-square Nov 16, 2024
7312e2b
Update snapshots
meherkasam-square Nov 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ...4/SnapshotTests.AccessibilitySnapshotTests/[email protected]
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...4/SnapshotTests.AccessibilitySnapshotTests/[email protected]
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...4/SnapshotTests.AccessibilitySnapshotTests/[email protected]
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions Sources/AccessibilitySnapshot/Core/Swift/Assets/de.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@
/* Description for the 'back button' accessibility trait */
"trait.backbutton.description" = "Zurück Taste.";

/* Description for the 'keyboard key' accessibility trait */
"trait.keyboard_key.description" = "Tastaturtaste.";

/* Description for the 'tab' accessibility trait */
"trait.tab.description" = "Tabulator.";

Expand Down
3 changes: 3 additions & 0 deletions Sources/AccessibilitySnapshot/Core/Swift/Assets/en.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@
/* Description for the 'back button' accessibility trait */
"trait.backbutton.description" = "Back Button.";

/* Description for the 'keyboard key' accessibility trait */
"trait.keyboard_key.description" = "Keyboard Key.";

/* Description for the 'tab' accessibility trait */
"trait.tab.description" = "Tab.";

Expand Down
3 changes: 3 additions & 0 deletions Sources/AccessibilitySnapshot/Core/Swift/Assets/ru.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@
/* Description for the 'back button' accessibility trait */
"trait.backbutton.description" = "Кнопка назад.";

/* Description for the 'keyboard key' accessibility trait */
"trait.keyboard_key.description" = "Клавиша клавиатуры.";

/* Description for the 'tab' accessibility trait */
"trait.tab.description" = "Вкладка.";

Expand Down
11 changes: 11 additions & 0 deletions Sources/AccessibilitySnapshot/Core/Swift/Classes/UIAccessibility+SnapshotAdditions.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,10 @@ extension NSObject {
traitSpecifiers.append(strings.backButtonTraitName)
}

if accessibilityTraits.contains(.keyboardKey) {
traitSpecifiers.append(strings.keyboardKeyTraitName)
}

if accessibilityTraits.contains(.switchButton) {
if accessibilityTraits.contains(.button) {
// An element can have the private switch button trait without being a UISwitch (for example, by passing
Expand Down Expand Up @@ -326,6 +330,8 @@ extension NSObject {

let backButtonTraitName: String

let keyboardKeyTraitName: String

let tabTraitName: String

let headerTraitName: String
Expand Down Expand Up @@ -410,6 +416,11 @@ extension NSObject {
comment: "Description for the 'back button' accessibility trait",
locale: locale
)
self.keyboardKeyTraitName = "Keyboard Key.".localized(
key: "trait.keyboard_key.description",
comment: "Description for the 'keyboard key' accessibility trait",
locale: locale
)
self.tabTraitName = "Tab.".localized(
key: "trait.tab.description",
comment: "Description for the 'tab' accessibility trait",
Expand Down
Loading