Add support for back button accessibility trait. #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyalPineapple
requested review from
elzinke and
meherkasam
and removed request for
elzinke
kyleve
reviewed
Jul 30, 2024
| @@ -10,6 +10,9 @@ | |||
| /* Description for the 'button' accessibility trait */ | |||
| "trait.button.description" = "Taste."; | |||
|
|
|||
| /* Description for the 'back button' accessibility trait */ | |||
| "trait.backbutton.description" = "Zurück Taste."; | |||
RoyalPineapple
changed the title
NickEntin
reviewed
Aug 4, 2024
kyleve
reviewed
Aug 6, 2024
There was a problem hiding this comment.
Yay, thanks for doing this!
RoyalPineapple
force-pushed
the
alex/BackButton
branch
from
a1d6e9d
to
544607f
Compare
@NickEntin I added snapshot tests as you suggested. Do you mind a re-review? |
kyleve
reviewed
Aug 8, 2024
Example/AccessibilitySnapshot/NavBarBackButtonAccessibilityTraitsViewController.swift
Outdated
Show resolved
Hide resolved
Example/AccessibilitySnapshot/NavBarBackButtonAccessibilityTraitsViewController.swift
Outdated
Show resolved
Hide resolved
Example/AccessibilitySnapshot/NavBarBackButtonAccessibilityTraitsViewController.swift
Outdated
Show resolved
Hide resolved
RoyalPineapple
force-pushed
the
alex/BackButton
branch
from
9ce0a7d
to
0bf9486
Compare
RoyalPineapple
force-pushed
the
alex/BackButton
branch
from
0bf9486
to
b562642
Compare
meherkasam
approved these changes
Nov 1, 2024
RoyalPineapple
force-pushed
the
alex/BackButton
branch
from
b562642
to
af462b7
Compare
RoyalPineapple
force-pushed
the
alex/BackButton
branch
from
af462b7
to
3e09f4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Navigation controller back buttons contain a secret menu trait which calls them out with a distinct utterance of "back button" rather than simply "button". This change adds support for detecting this trait and provides the matching utterance string.