Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add snapshot tests for iOS 17 #195

Merged
merged 1 commit into from
Jan 27, 2024
Merged

Add snapshot tests for iOS 17 #195

merged 1 commit into from
Jan 27, 2024

Conversation

NickEntin
Copy link
Collaborator

Resolves #155

NickEntin
NickEntin commented Jan 24, 2024
View reviewed changes
.../_64/SnapshotTests.AccessibilityContainersTests/[email protected]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data table descriptions are still incorrect on iOS 17, see #7

...enceImages/_64/SnapshotTests.AccessibilitySnapshotTests/[email protected] Show resolved Hide resolved
...enceImages/_64/SnapshotTests.AccessibilitySnapshotTests/[email protected] Show resolved Hide resolved
...ceImages/_64/SnapshotTests.AccessibilitySnapshotTests/[email protected]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last three now read:

"Fake label, Switch button, on" / "Double tap to toggle setting."
"Fake label, Switch button 3" / "Double tap to toggle setting."
"Fake label, Switch button value" / "Double tap to toggle setting."

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed as #199

...ReferenceImages/_64/SnapshotTests.AccessibilitySnapshotTests/[email protected]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few differences in this one. Interestingly in the second row Item B now includes "3 items" in the description. Updated #26 with these findings.

Copy link
Collaborator Author

@NickEntin NickEntin Jan 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interestingly this one got fixed in the CI snapshot updates. Maybe it's flaky? Will look at it closer when we address #26.

...pshotTests.ActivationPointTests/[email protected] Show resolved Hide resolved
.../ReferenceImages/_64/SnapshotTests.DefaultControlsTests/[email protected]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should still say "decrement" and "increment"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell this is somewhat flaky. Not sure what's going on here. Same root problem as #29, but maybe less common. I'll keep an eye on it.

...sts/__Snapshots__/SnapshotTestingTests/testShowingActivationPoint.always-393x852-17-2-3x.png Show resolved Hide resolved
@NickEntin NickEntin force-pushed the entin/ios-17 branch 2 times, most recently from 1b2f58a to 0d90140 Compare January 25, 2024 01:12
Base automatically changed from entin/fix-rebinding-crash to master January 25, 2024 22:20
@NickEntin NickEntin changed the base branch from master to entin/sub-pixel-activation-point January 26, 2024 04:07
@NickEntin NickEntin linked an issue Jan 26, 2024 that may be closed by this pull request
Add snapshot tests for iOS 17 and audit results #155
Closed
@NickEntin NickEntin marked this pull request as ready for review January 26, 2024 05:28
@NickEntin NickEntin mentioned this pull request Jan 26, 2024
Open
Base automatically changed from entin/sub-pixel-activation-point to master January 27, 2024 00:16
@NickEntin NickEntin merged commit 8179c09 into master Jan 27, 2024
8 checks passed
@NickEntin NickEntin deleted the entin/ios-17 branch January 27, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kruegermj kruegermj kruegermj approved these changes

@RoyalPineapple RoyalPineapple Awaiting requested review from RoyalPineapple

@meherkasam meherkasam Awaiting requested review from meherkasam

@luispadron luispadron Awaiting requested review from luispadron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add snapshot tests for iOS 17 and audit results
2 participants
@NickEntin @kruegermj